Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New domain notline.localplayer.dev #1919

Merged
merged 5 commits into from
Jan 11, 2025
Merged

New domain notline.localplayer.dev #1919

merged 5 commits into from
Jan 11, 2025

Conversation

dav2010ID
Copy link
Contributor

@dav2010ID dav2010ID commented Jan 10, 2025 •
edited
Loading

Requirements

  • You have completed your website.
  • The website is reachable.
  • The CNAME record doesn't contain https:// or /.
  • There is sufficient information at the owner field.
  • There is no NS Records (Enforced as of Sepetember 4th, 2024)

Description

Testing my code

Link to Website

http://74.234.45.159/

@dav2010ID dav2010ID requested a review from a team as a code owner January 10, 2025 20:08
@open-domains
Copy link

open-domains bot commented Jan 10, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@open-domains open-domains bot added the CLA Required Contributor has not signed the CLA. label Jan 10, 2025
@dav2010ID
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

open-domains bot added a commit to open-domains/cla that referenced this pull request Jan 10, 2025
@open-domains
@dav2010ID has signed the CLA in open-domains/register#1919
1c94cb3
@open-domains open-domains bot added CLA Signed Contributor has signed the CLA and removed CLA Required Contributor has not signed the CLA. labels Jan 10, 2025
DEV-DIBSTER
DEV-DIBSTER requested changes Jan 11, 2025
View reviewed changes
domains/notline.domain.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain in the file should be replaced with the domain you are requesting.

domains/notline.domain.json Outdated
},

"record": {
"A": ["74.234.45.159"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to see the site, please provide a preview.

@DEV-DIBSTER DEV-DIBSTER added Invalid: File File provided is mismatched or not properly formatted. Invalid: Inaccessible Site Site or records provided cannot show a site. labels Jan 11, 2025
@dav2010ID
Copy link
Contributor Author

Sorry, I forgot to run the server, but I've done it now.

@dav2010ID dav2010ID requested a review from DEV-DIBSTER January 11, 2025 11:29
@DEV-DIBSTER DEV-DIBSTER merged commit 1803aa1 into open-domains:main Jan 11, 2025
5 checks passed
@open-domains
Copy link

open-domains bot commented Jan 11, 2025

Pull Request Merged

Buy Me a Coffee

What's next?

Just follow the steps below and you can start using your domain!

GitHub Pages

  • Go to your GitHub repository that you use for your domain.
  • Click on the Settings tab.
  • Click on the Pages link in the sidebar.
  • In the custom domain option, enter the domain you registered.
  • Check the Enforce HTTPS checkbox.
  • Give your domain some time (~24 hours) for the changes to propagate.
  • Enjoy your domain!

Server Owners

For HTTPS, you will have to configure an SSL certificate to allow the new subdomain to work (here's why).

Need help with your domain? If you have troubles setting up your domain, please create an issue and we will try and help you as soon as possible!

Made a mistake in the records? Don't worry, you can create a new pull request with the corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DEV-DIBSTER DEV-DIBSTER DEV-DIBSTER approved these changes

Assignees
No one assigned
Labels
CLA Signed Contributor has signed the CLA Invalid: File File provided is mismatched or not properly formatted. Invalid: Inaccessible Site Site or records provided cannot show a site.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dav2010ID @DEV-DIBSTER