Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create *oli-mebberson.is-cool.dev.json #1967

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Create *oli-mebberson.is-cool.dev.json #1967

merged 5 commits into from
Feb 10, 2025

Conversation

olii-dev
Copy link
Contributor

Requirements

  • You have completed your website.
  • The website is reachable.
  • The CNAME record doesn't contain https:// or /.
  • There is sufficient information at the owner field.
  • There is no NS Records (Enforced as of Sepetember 4th, 2024)

Description

I will be using the domain for my portfolio website which is personal

Link to Website

https://github.com/olii-dev/aboutme

@olii-dev olii-dev requested a review from a team as a code owner January 25, 2025 21:42
@open-domains open-domains bot added the CLA Signed Contributor has signed the CLA label Jan 25, 2025
DEV-DIBSTER
DEV-DIBSTER requested changes Jan 28, 2025
View reviewed changes
domains/*oli-mebberson.is-cool.dev.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid file. Wildcards are not done like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I do them then? I followed the instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DEV-DIBSTER I just fixed all the issues i could think of that are possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for wildcard records?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand?

Copy link
Contributor Author

@olii-dev olii-dev Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, yeah I just need a normal A record, so I will adjust that, sorry and thanks!

Edit: I can't find where I do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the three dot menu, and hit edit file. You can then click on the name and edit it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so i just need to remove the * ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kyro3400 ive done that right?

@DEV-DIBSTER DEV-DIBSTER added the Invalid: File File provided is mismatched or not properly formatted. label Jan 28, 2025
@open-domains
Copy link

open-domains bot commented Feb 3, 2025

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 11 days.

@open-domains open-domains bot added Awaiting Response Await response from the original contributor. and removed Awaiting Response Await response from the original contributor. labels Feb 3, 2025
@open-domains
Copy link

open-domains bot commented Feb 10, 2025

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 11 days.

@open-domains open-domains bot added the Awaiting Response Await response from the original contributor. label Feb 10, 2025
@DEV-DIBSTER DEV-DIBSTER merged commit 11f40bb into open-domains:main Feb 10, 2025
5 checks passed
@open-domains
Copy link

open-domains bot commented Feb 10, 2025

Pull Request Merged

Buy Me a Coffee

What's next?

Just follow the steps below and you can start using your domain!

GitHub Pages

  • Go to your GitHub repository that you use for your domain.
  • Click on the Settings tab.
  • Click on the Pages link in the sidebar.
  • In the custom domain option, enter the domain you registered.
  • Check the Enforce HTTPS checkbox.
  • Give your domain some time (~24 hours) for the changes to propagate.
  • Enjoy your domain!

Server Owners

For HTTPS, you will have to configure an SSL certificate to allow the new subdomain to work (here's why).

Need help with your domain? If you have troubles setting up your domain, please create an issue and we will try and help you as soon as possible!

Made a mistake in the records? Don't worry, you can create a new pull request with the corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyro3400 Kyro3400 Kyro3400 left review comments

@DEV-DIBSTER DEV-DIBSTER DEV-DIBSTER approved these changes

Assignees
No one assigned
Labels
Awaiting Response Await response from the original contributor. CLA Signed Contributor has signed the CLA Invalid: File File provided is mismatched or not properly formatted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olii-dev @Kyro3400 @DEV-DIBSTER