feat: Adding a Provider implementation on top of the standard dotnet FeatureManagement system. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpattison
changed the title
ericpattison
force-pushed
the
feature/FeatureManagementProvider
branch
from
6fe721d to
5dc3a85
Compare
ericpattison
force-pushed
the
feature/FeatureManagementProvider
branch
from
af5ed19 to
ba4bb99
Compare
github-actions
bot
requested review from
matthewelwell,
thomaspoignant and
vpetrusevici
Signed-off-by: Eric Pattison <[email protected]>
Signed-off-by: Eric Pattison <[email protected]>
Signed-off-by: Austin Drenski <[email protected]> Signed-off-by: Eric Pattison <[email protected]>
Signed-off-by: Austin Drenski <[email protected]> Signed-off-by: Eric Pattison <[email protected]>
fixing some whitespace issues Signed-off-by: Eric Pattison <[email protected]>
Signed-off-by: Eric Pattison <[email protected]>
…re#128) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Eric Pattison <[email protected]>
ericpattison
force-pushed
the
feature/FeatureManagementProvider
branch
from
ba4bb99 to
4921e15
Compare
|
@toddbaert @bacherfl could you please review this tomorrow? |
bacherfl
reviewed
Jan 11, 2024
| if (userId.IsString) targetingContext.UserId = userId.AsString; | ||
| } | ||
|
|
||
| if (evaluationContext.ContainsKey("Groups")) |
There was a problem hiding this comment.
nitpick: I suggest to add a constant for UserId and Groups
bacherfl
reviewed
Jan 11, 2024
| [Theory] | ||
| [InlineData(true)] | ||
| [InlineData(false)] | ||
| public async Task MissingFlagKey_ShouldReturnDefault(bool defaultValue) |
There was a problem hiding this comment.
for the sake of completeness, I suggest to also add test cases for the other data types (i.e. ResolveStringValue, etc.) to check if the default value is returned in case the flag is not found in the configuration
bacherfl
reviewed
Jan 11, 2024
...e.Contrib.Providers.FeatureManagement/OpenFeature.Contrib.Providers.FeatureManagement.csproj
Outdated
Show resolved
Hide resolved
…e.Contrib.Providers.FeatureManagement.csproj Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: ericpattison <[email protected]>
removing BOM that was added to csproj replacing hardcoded strings with nameofs Signed-off-by: Eric Pattison <[email protected]>
…ttison/dotnet-sdk-contrib into feature/FeatureManagementProvider Signed-off-by: Eric Pattison <[email protected]>
|
Updated to address @bacherfl's suggestions. |
bacherfl
approved these changes
Jan 12, 2024
Seems like i did not see the failing dotnet-format check - can you please address that one? Other than that the implementation looks good to me |
Signed-off-by: Eric Pattison <[email protected]>
This was referenced Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently dependent on a preview feature being added to the standard dotnet FeatureManagement library called Variants.
This new feature is required as with out it, features are either on or off. Variants allow feature flags to provide configuration based values.