Change EventMetadata type #234
Assignees
Labels
breaking-change
Changes in exposed interfaces or behaviour
good first issue
Good for newcomers
help wanted
Extra attention is needed
Milestone
Comments
askpt
added
good first issue
Merged
benjiro
added a commit
that referenced
this issue
Feb 21, 2024
The spec describes two types(flag metadata, and event metadata) that are functionally the same. This PR makes a breaking change to bring both of the types to use a generic ImmutableMetadata type. - Rename BaseMetadata to Immutable, make sealed class and implement a empty constructor Fixes: #234 Signed-off-by: Benjamin Evenson <[email protected]>
benjiro
added a commit
that referenced
this issue
Feb 24, 2024
The spec describes two types(flag metadata, and event metadata) that are functionally the same. This PR makes a breaking change to bring both of the types to use a generic ImmutableMetadata type. - Rename BaseMetadata to Immutable, make sealed class and implement a empty constructor Fixes: #234 Signed-off-by: Benjamin Evenson <[email protected]>
toddbaert
pushed a commit
that referenced
this issue
Apr 22, 2024
The spec describes two types(flag metadata, and event metadata) that are functionally the same. This PR makes a breaking change to bring both of the types to use a generic ImmutableMetadata type. - Rename BaseMetadata to Immutable, make sealed class and implement a empty constructor Fixes: #234 Signed-off-by: Benjamin Evenson <[email protected]>
toddbaert
pushed a commit
that referenced
this issue
Apr 22, 2024
The spec describes two types(flag metadata, and event metadata) that are functionally the same. This PR makes a breaking change to bring both of the types to use a generic ImmutableMetadata type. - Rename BaseMetadata to Immutable, make sealed class and implement a empty constructor Fixes: #234 Signed-off-by: Benjamin Evenson <[email protected]>
arttonoyan
pushed a commit
to arttonoyan/dotnet-sdk
that referenced
this issue
Nov 17, 2024
…re#241) ## This PR **BREAKING CHANGE**, merge with 2.0 The spec describes two types(flag metadata, and event metadata) that are functionally the same. This PR makes a breaking change to bring both of the types to use a generic ImmutableMetadata type. - Rename BaseMetadata to ImmutableMetadata, make sealed class and implement a empty constructor ### Related Issues Fixes: open-feature#234 --------- Signed-off-by: Benjamin Evenson <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Artyom Tonoyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FlagMetadataandEventMetadataare shaped the same in the SDK:I think for consistency, that means we should use the same type for these, which I guess would mean it should be a
Dictionary<string, object>()unless there's some way we can bring them in line with your new implementation in a non-breaking way... maybe with extension methods?Originally posted by @toddbaert in #223 (comment)
The text was updated successfully, but these errors were encountered: