Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix go module #125

Closed
2 tasks
toddbaert opened this issue Jan 16, 2024 · 0 comments · Fixed by #128
Closed
2 tasks

[BUG] fix go module #125

toddbaert opened this issue Jan 16, 2024 · 0 comments · Fixed by #128

Comments

@toddbaert
Copy link
Member

toddbaert commented Jan 16, 2024

When we renamed https://github.com/open-feature/schemas to https://github.com/open-feature/flagd-schemas, we never changed the go module name, and the package isn't being indexed properly at https://pkg.go.dev/github.com/open-feature/flagd-schemas, so we're forced to rely on a specific sha instead of a proper release here.

Originally posted by @toddbaert in open-feature/flagd#1146 (comment)

tasks:

@toddbaert toddbaert changed the title [BUG] fix go mo [BUG] fix go module Jan 16, 2024
toddbaert added a commit that referenced this issue Jan 18, 2024
- Fixes module location
- changes flagd root level schema name to `flags.json` instead of
`flagd_definitions`
- "flags" is the main top level object of the root schema, and though we
have others (like `$evalutors` they are optional and used in `flags`.
- it seems much more sensible as a public schema:
https://flagd.dev/schema/v0/flagd-definitions.json vs
https://flagd.dev/schema/v0/flags.json

Fixes: #125

Signed-off-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant