Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: struct for metadata for consistency and power #130

Merged
merged 3 commits into from
Feb 15, 2024
Merged

feat!: struct for metadata for consistency and power #130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
705c84a
feat!: use struct for metadatas
toddbaert Feb 7, 2024
65cfd33
fixup: add import
toddbaert Feb 7, 2024
4e0c2f2
fixup: reserve 1
toddbaert Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions protobuf/flagd/sync/v1/sync.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/**

Check failure on line 1 in protobuf/flagd/sync/v1/sync.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Previously present message "KeyValue" was deleted from file.
* Flag definition sync API
*
* This proto defines a simple API to synchronize a feature flag definition.
Expand All @@ -8,6 +8,8 @@

package flagd.sync.v1;

import "google/protobuf/struct.proto";

option csharp_namespace = "OpenFeature.Flagd.Grpc.Sync";
option go_package = "flagd/sync/v1";
option java_package = "dev.openfeature.flagd.grpc.sync";
Expand Down Expand Up @@ -63,14 +65,9 @@
message GetMetadataRequest {}

// GetMetadataResponse contains metadata from the sync service
message GetMetadataResponse {

Check failure on line 68 in protobuf/flagd/sync/v1/sync.proto

View workflow job for this annotation

GitHub Actions / buf-breaking-changes 

Previously present field "1" with name "metadata" on message "GetMetadataResponse" was deleted.
repeated KeyValue metadata = 1;
}

// KeyValue represents a key/value pair
message KeyValue {
string key = 1;
string value = 2;
reserved 1; // old key/value metadata impl
google.protobuf.Struct metadata = 2;
}

// FlagService implements a server streaming to provide realtime flag configurations
Expand Down
Loading