-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix lint errors #987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
toddbaert
commented
Nov 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #987 +/- ##
==========================================
- Coverage 72.63% 72.53% -0.11%
==========================================
Files 28 28
Lines 2858 2858
==========================================
- Hits 2076 2073 -3
- Misses 685 687 +2
- Partials 97 98 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
reviewed
Nov 1, 2023
toddbaert
commented
Nov 1, 2023
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Nov 1, 2023
Merged
Kavindu-Dodan
pushed a commit
that referenced
this pull request
Nov 13, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.6.8</summary> ## [0.6.8](flagd/v0.6.7...flagd/v0.6.8) (2023-11-13) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.6.7 ([#966](#966)) ([c038a3a](c038a3a)) * **deps:** update module github.com/open-feature/go-sdk to v1.8.0 ([#994](#994)) ([266cf9f](266cf9f)) * **deps:** update module github.com/open-feature/go-sdk-contrib/tests/flagd to v1.3.1 ([#760](#760)) ([30dda72](30dda72)) * **deps:** update module github.com/spf13/cobra to v1.8.0 ([#993](#993)) ([05c7870](05c7870)) ### 🧹 Chore * fix lint errors ([#987](#987)) ([0c3af2d](0c3af2d)) ### 🔄 Refactoring * migrate to connectrpc/connect-go ([#990](#990)) ([7dd5b2b](7dd5b2b)) </details> <details><summary>flagd-proxy: 0.2.13</summary> ## [0.2.13](flagd-proxy/v0.2.12...flagd-proxy/v0.2.13) (2023-11-13) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.6.7 ([#966](#966)) ([c038a3a](c038a3a)) * **deps:** update module github.com/spf13/cobra to v1.8.0 ([#993](#993)) ([05c7870](05c7870)) ### 🔄 Refactoring * migrate to connectrpc/connect-go ([#990](#990)) ([7dd5b2b](7dd5b2b)) </details> <details><summary>core: 0.6.8</summary> ## [0.6.8](core/v0.6.7...core/v0.6.8) (2023-11-13) ### 🐛 Bug Fixes * **deps:** update golang.org/x/exp digest to 9a3e603 ([#929](#929)) ([f8db930](f8db930)) * **deps:** update kubernetes packages to v0.28.3 ([#974](#974)) ([d7d205f](d7d205f)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.3.1 ([#971](#971)) ([f1a40b8](f1a40b8)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.3.2 ([#975](#975)) ([b53c14a](b53c14a)) * **deps:** update module github.com/fsnotify/fsnotify to v1.7.0 ([#981](#981)) ([727b9d2](727b9d2)) * **deps:** update module golang.org/x/mod to v0.14.0 ([#991](#991)) ([87bc12d](87bc12d)) * **deps:** update module golang.org/x/net to v0.17.0 [security] ([#963](#963)) ([7f54bd1](7f54bd1)) * **deps:** update module golang.org/x/net to v0.18.0 ([#1000](#1000)) ([e9347cc](e9347cc)) * **deps:** update module golang.org/x/sync to v0.5.0 ([#992](#992)) ([bd24536](bd24536)) * **deps:** update module google.golang.org/grpc to v1.59.0 ([#972](#972)) ([7d0f1f2](7d0f1f2)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.16.3 ([#976](#976)) ([b33c9c9](b33c9c9)) * **deps:** update opentelemetry-go monorepo ([#1001](#1001)) ([9798aeb](9798aeb)) ### 🔄 Refactoring * migrate to connectrpc/connect-go ([#990](#990)) ([7dd5b2b](7dd5b2b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few lint issues, directly, and by ignoring some submodules.