Skip to content

Commit

Permalink
chore: update min SDK version
Browse files Browse the repository at this point in the history
Signed-off-by: Todd Baert <[email protected]>
  • Loading branch information
toddbaert committed Jan 10, 2025
1 parent 8fb4194 commit ccf73fa
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void error(HookContext ctx, Exception error, Map hints) {
}

@Override
public void finallyAfter(HookContext ctx, Map hints) {
public void finallyAfter(HookContext ctx, FlagEvaluationDetails details, Map hints) {
activeFlagEvaluationsCounter.add(-1, Attributes.of(flagKeyAttributeKey, ctx.getFlagKey()));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public void finally_stage_validation() {
final MetricsHook metricHook = new MetricsHook(telemetryExtension.getOpenTelemetry());

// when
metricHook.finallyAfter(commonHookContext, null);
metricHook.finallyAfter(commonHookContext, null, null);
List<MetricData> metrics = telemetryExtension.getMetrics();

// then
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
<!-- this can be overriden in child POMs to support specific SDK requirements -->
<groupId>dev.openfeature</groupId>
<artifactId>sdk</artifactId>
<!-- 1.12 <= v < 2.0 -->
<version>[1.12,2.0)</version>
<!-- 1.14 <= v < 2.0 (excluding 2.0 pre-releases)-->
<version>[1.14,2.0)</version>
<!-- use the version provided at runtime -->
<scope>provided</scope>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import dev.openfeature.sdk.Value;
import dev.openfeature.sdk.exceptions.ParseError;
import dev.openfeature.sdk.exceptions.TypeMismatchError;
import java.util.Map;
import java.util.function.Consumer;
import java.util.function.Supplier;
import lombok.extern.slf4j.Slf4j;
Expand Down

0 comments on commit ccf73fa

Please sign in to comment.