-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use EvenEmitter3 for web-sdk #847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Reining <[email protected]>
lukas-reining
commented
Mar 5, 2024
lukas-reining
commented
Mar 5, 2024
Signed-off-by: Todd Baert <[email protected]>
@lukas-reining @beeme1mr I pushed a small change to remove |
toddbaert
approved these changes
Mar 5, 2024
Ah sure missed that one thanks! |
beeme1mr
approved these changes
Mar 5, 2024
This was referenced Mar 5, 2024
toddbaert
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.28](core-v0.0.27...core-v0.0.28) (2024-03-05) ### ✨ New Features * use EvenEmitter3 for web-sdk ([#847](#847)) ([861cf83](861cf83)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.15](web-sdk-v0.4.14...web-sdk-v0.4.15) (2024-03-05) ### ✨ New Features * use EvenEmitter3 for web-sdk ([#847](#847)) ([861cf83](861cf83)) ### 🧹 Chore * **main:** release core 0.0.28 ([#849](#849)) ([31b92a9](31b92a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes an issue where the
events
node polyfill does not comply to thenode:events
types.When trying to use the web OpenFeatureEventEmitter the following error message comes up, describing that the
events
polyfill's EventEmitter is incompatible tonode:events
EventEmitter.This PR fixes that issue by not using the
events
anymore and instead using https://www.npmjs.com/package/eventemitter3cc @toddbaert
Related Issues
Fixes #845