fix: declaration for provider name

[apodgorbunschih]

The implementation is not fulfilling the abstraction definition:
https://github.com/open-feature/php-sdk/blob/4e25be68937dc4ec405366cb6ba726f66fc0e5c8/src/implementation/provider/AbstractProvider.php#L19

protected static string $NAME = 'AbstractProvider';

The implementation is pointing not to a property but to a constant.

protected const NAME = 'SplitProvider';

This is leading to getMetadata method in the implementation to return all the time "AbstractProvider" value

Reproducing the issues:

<?php
abstract class AbstractProvider {
  protected static string $NAME = 'AbstractProvider';
  
  public function getMetadata()
  {
      return static::$NAME;
  }
}

class SplitProvider extends AbstractProvider
{
    protected const NAME = 'SplitProvider';
}

class FlagdProvider extends AbstractProvider
{
    protected const NAME = 'FlagdProvider';
}

$splitProvider = new SplitProvider();
var_dump($splitProvider->getMetadata());


$flagDProvider = new FlagdProvider();
var_dump($flagDProvider->getMetadata());
?>

[tcarrio]

This looks good to me, the lazy static binding was merged in the php-sdk but these weren't updated with it.

Thank you @apodgorbunschih!

If the tests for the providers don't cover this already, it will be a good follow-up to ensure it doesn't break again

[apodgorbunschih]

@tcarrio Thanks a lot. Let me add the test in this MR, so we will be sure that is returning the correct value 👍