-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evaluation context requirement to allow fetching all custom fields #120
Merged
beeme1mr
merged 5 commits into
open-feature:main
from
rgrassian-split:evalContextFetchAll
Aug 3, 2022
Merged
evaluation context requirement to allow fetching all custom fields #120
beeme1mr
merged 5 commits into
open-feature:main
from
rgrassian-split:evalContextFetchAll
Aug 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrassian-split
requested review from
oleg-nenashev and
toddbaert
as code owners
August 2, 2022 20:45
Signed-off-by: Robert Grassian <[email protected]>
rgrassian-split
force-pushed
the
evalContextFetchAll
branch
from
August 2, 2022 20:47
b417b9a
to
241a675
Compare
justinabrahms
approved these changes
Aug 2, 2022
Co-authored-by: Justin Abrahms <[email protected]> Signed-off-by: Robert Grassian <[email protected]>
kinyoklion
reviewed
Aug 2, 2022
beeme1mr
approved these changes
Aug 2, 2022
thomaspoignant
approved these changes
Aug 3, 2022
james-milligan
approved these changes
Aug 3, 2022
thomaspoignant
requested changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have update the specification.json
file, could you run make parse
to have it in the PR ?
Signed-off-by: Robert Grassian <[email protected]>
… into evalContextFetchAll
@rgrassian-split, please rerun the generator when you have a moment. |
Signed-off-by: Robert Grassian <[email protected]>
benjiro
added a commit
to open-feature/dotnet-sdk
that referenced
this pull request
Aug 4, 2022
open-feature/spec#120 Signed-off-by: Benjamin Evenson <[email protected]>
benjiro
added a commit
to open-feature/dotnet-sdk
that referenced
this pull request
Aug 4, 2022
open-feature/spec#120 Signed-off-by: Benjamin Evenson <[email protected]>
benjiro
added a commit
to open-feature/dotnet-sdk
that referenced
this pull request
Aug 4, 2022
open-feature/spec#120 Signed-off-by: Benjamin Evenson <[email protected]>
This was referenced Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.