EvaluationContext each key should be unique #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
requested review from
oleg-nenashev and
toddbaert
as code owners
thomaspoignant
changed the title
beeme1mr
reviewed
Aug 3, 2022
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
evaluation-context-uniq-keys
branch
from
96a2218 to
2d2ffa4
Compare
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
evaluation-context-uniq-keys
branch
from
14e08e9 to
b19d87f
Compare
justinabrahms
approved these changes
Aug 3, 2022
beeme1mr
approved these changes
Aug 3, 2022
InTheCloudDan
approved these changes
Aug 3, 2022
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
This was referenced Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion here and this issue, I believe it is necessary to explicitly say that each key from the
EvaluationContextshould be unique.