feat: STALE state, run handlers for current state immediately, provider name #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
justinabrahms,
beeme1mr,
Kavindu-Dodan,
lukas-reining,
benjiro,
kinyoklion,
thomaspoignant and
thiyagu06
toddbaert
force-pushed
the
fix/clarity-and-events
branch
from
5964658 to
81c3c96
Compare
toddbaert
commented
Jun 23, 2023
beeme1mr
reviewed
Jun 23, 2023
toddbaert
requested review from
moredip,
Kavindu-Dodan,
beeme1mr and
justinabrahms
toddbaert
force-pushed
the
fix/clarity-and-events
branch
from
cb71596 to
31b9ce8
Compare
beeme1mr
previously approved these changes
Jul 12, 2023
toddbaert
commented
Jul 20, 2023
toddbaert
commented
Jul 20, 2023
toddbaert
commented
Jul 20, 2023
* Adds additional clarity regarding provider/client name mapping, as well as intent. * Requires that READY events only run immediately for clients when the provider is already ready. * Replaces client-name for provider-name in events-details. Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Justin Abrahms <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/clarity-and-events
branch
from
7726130 to
3f56549
Compare
Signed-off-by: Todd Baert <[email protected]>
|
@Kavindu-Dodan @lukas-reining @beeme1mr @Kavindu-Dodan I've updated this PR. Please re-review. The main change is the addition of the |
beeme1mr
approved these changes
Aug 11, 2023
Kavindu-Dodan
approved these changes
Aug 11, 2023
Signed-off-by: Todd Baert <[email protected]>
toddbaert
changed the title
toddbaert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only functional changes here are small ones related to events, and a new provider state, so particularly interested in @Kavindu-Dodan and @lukas-reining 's opinions on this one.
Relates to #200, which depends on
STALEstate.