Client creation must not throw #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeme1mr
reviewed
Jun 7, 2022
moredip
approved these changes
Jun 8, 2022
toddbaert
force-pushed
the
feat/client-creation-no-throw
branch
from
7cf5120 to
f12d67d
Compare
|
Another FYI @justinabrahms and @davejohnston , though I don't expect this will be much of a change, especially for golang, with no exceptions and where' the "zero value" of the client is probably a no-op anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title, based on discussion here: #44
Closes: #44