[OF#5006] Update addressNL component to manually fill in city and streetname #775
Conversation
Bundle ReportChanges will increase total bundle size by 2.15kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 83.65% 83.73% +0.08%
==========================================
Files 244 244
Lines 4777 4796 +19
Branches 1268 1273 +5
==========================================
+ Hits 3996 4016 +20
+ Misses 748 747 -1
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
2 times, most recently
from
706b6c6 to
cbcde0f
Compare
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
from
cbcde0f to
e6d7ded
Compare
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
from
e6d7ded to
e9f4b55
Compare
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
2 times, most recently
from
8cdb120 to
f5599a0
Compare
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
2 times, most recently
from
1d1a28a to
a9f8193
Compare
Yes, I am not exactly sure about this either, but I chose to do it like this after some investigation in the code. |
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
from
a9f8193 to
40eba22
Compare
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
from
40eba22 to
7369d3d
Compare
| await userEvent.type(postcodeInput, '1017 CJ'); | ||
|
|
||
| // wait for the check logic api call | ||
| await sleep(1800); |
There was a problem hiding this comment.
If I understood it correctly, the button is disabled for all this time, so I have to wait for it and then click on it.
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
from
7369d3d to
eb69adc
Compare
…ually fill in city and streetname Until now the addressNL component would retrieve the city and street name based on the postcode and housenumber. These fields were always read-only but now we want to be able to fill in city and street name if something goes wrong with the API call.
vaszig
force-pushed
the
of-5006/addressnl-ability-to-manually-edit-streetname-and-city
branch
from
eb69adc to
93b9e8b
Compare
Closes open-formulieren/open-forms#5006 partly
Until now the
addressNLcomponent would retrieve the city and street name based on the postcode and housenumber. These fields were always read-only but now we want to be able to fill in city and street name manually if something goes wrong with the API call.