Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressNL unreliable validation fix #790

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

robinmolen
Copy link
Contributor

Make sure that get emptyValue() stays a regular function. Making the get emptyValue() static results into weird validation issues, broken e2e tests, and general unpleasant behavior.

Make sure that `get emptyValue()` stays a regular function. Making the `get emptyValue()` static results into weird validation issues, broken e2e tests, and general unpleassant behavior.
Copy link

codecov bot commented Jan 30, 2025

Bundle Report

Changes will increase total bundle size by 176 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.77MB 88 bytes (0.0%) ⬆️
@open-formulieren/sdk-esm 4.75MB 88 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @open-formulieren/sdk-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/formio-*.js 88 bytes 2.03MB 0.0%

Files in assets/formio-*.js:

  • ./src/formio/components/AddressNL.jsx → Total Size: 13.71kB
view changes for bundle: @open-formulieren/sdk-OpenForms-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
open-*.js 88 bytes 3.49MB 0.0%

Files in open-*.js:

  • ./src/formio/components/AddressNL.jsx → Total Size: 13.73kB

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (263df05) to head (e70a702).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
+ Coverage   83.65%   83.67%   +0.02%     
==========================================
  Files         244      244              
  Lines        4777     4777              
  Branches     1268     1268              
==========================================
+ Hits         3996     3997       +1     
+ Misses        748      747       -1     
  Partials       33       33              
Flag Coverage Δ
storybook 76.25% <100.00%> (ø)
vitest 63.00% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen merged commit 775bb98 into main Jan 30, 2025
15 of 17 checks passed
@robinmolen robinmolen deleted the fix/addressNL-e2e-ci-test branch January 30, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants