Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove login buttons when the submission limit is reached #793

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

viktorvanwijk
Copy link

@viktorvanwijk viktorvanwijk commented Feb 6, 2025

…sion limit is reached

Doesn't make much sense to show these buttons if users are unable to start a form because the submission limit has been reached.
Copy link

codecov bot commented Feb 6, 2025

Bundle Report

Changes will increase total bundle size by 60 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.78MB 30 bytes (0.0%) ⬆️
@open-formulieren/sdk-esm 4.75MB 30 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @open-formulieren/sdk-OpenForms-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
open-*.js 30 bytes 3.49MB 0.0%

Files in open-*.js:

  • ./src/components/FormStart/index.jsx → Total Size: 4.74kB
view changes for bundle: @open-formulieren/sdk-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/sdk-*.js 30 bytes 1.01MB 0.0%

Files in assets/sdk-*.js:

  • ./src/components/FormStart/index.jsx → Total Size: 4.74kB

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (c1f7d7e) to head (78fbd8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   84.23%   83.84%   -0.39%     
==========================================
  Files         245      245              
  Lines        4808     4810       +2     
  Branches     1279     1274       -5     
==========================================
- Hits         4050     4033      -17     
- Misses        729      748      +19     
  Partials       29       29              
Flag Coverage Δ
storybook 77.45% <100.00%> (-0.49%) ⬇️
vitest 62.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the maximum number of submissions is reached, don't show the button to login
1 participant