Opt-in to ESM bundle of SDK #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
feature/sdk-76-use-esm-bundle
branch
2 times, most recently
from
55a07ba to
9880ec4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5028 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 765 765
Lines 26125 26131 +6
Branches 3405 3407 +2
=======================================
+ Hits 25256 25262 +6
Misses 606 606
Partials 263 263 ☔ View full report in Codecov by Sentry. |
… if the browser supports it Using module type scripts makes it possible to opt into the benefits of bundle splitting where only code is loaded that will actually be used. This sets up a wrapper entrypoint/script gated behind the type=module feature of browsers so it's not executed by browsers that don't natively support modules yet. An extra advantage is that we can pass all the necessary configuration via data attributes and process them in our script, meaning we don't need inline scripts and CSP nonces anymore for this. Finally, the SDK ESM module is added to the preload list since we are guaranteed that we'll need it, and we avoid a waterfall when loading the entrypoint and then dynamically importing the SDK bundle - those can be fetched in parallel.
sergei-maertens
force-pushed
the
feature/sdk-76-use-esm-bundle
branch
from
9880ec4 to
56a5a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes open-formulieren/open-forms-sdk#76 - Depends on open-formulieren/open-forms-sdk#777
Changes
I'm not yet updating the documentation for how to embed the SDK until this is out of experimental phase.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene