Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5024] Remove uppercase validation of Domain in ZGW registration backend #5075

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

alextreme
Copy link
Contributor

@alextreme alextreme commented Feb 3, 2025

Closes #5024

Changes

Removing validation of Domain in ZGW registration backend

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@alextreme alextreme force-pushed the issue/5024-remove-uppercase-validation branch 2 times, most recently from 016d262 to cbdef5e Compare February 4, 2025 08:49
@alextreme alextreme force-pushed the issue/5024-remove-uppercase-validation branch from cbdef5e to a6e3f2f Compare February 4, 2025 11:10
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (3f79ba2) to head (a6e3f2f).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5075      +/-   ##
==========================================
- Coverage   96.72%   96.72%   -0.01%     
==========================================
  Files         770      770              
  Lines       26517    26516       -1     
  Branches     3454     3454              
==========================================
- Hits        25649    25648       -1     
  Misses        606      606              
  Partials      262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Feb 5, 2025
@alextreme alextreme marked this pull request as ready for review February 5, 2025 10:02
@sergei-maertens sergei-maertens removed the needs-backport Fix must be backported to stable release branch label Feb 5, 2025
@sergei-maertens
Copy link
Member

Checked with Alex and decided not to backport it because migrations complicate this process. It's okay if this only lands in 3.1.0

@sergei-maertens sergei-maertens merged commit a201a2a into master Feb 5, 2025
31 checks passed
@sergei-maertens sergei-maertens deleted the issue/5024-remove-uppercase-validation branch February 5, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZGW registration backend: validation that domain's must be uppercase seems incorrect
2 participants