Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process edit grid components in the json dump registration backend #5081

Conversation

viktorvanwijk
Copy link
Contributor

@viktorvanwijk viktorvanwijk commented Feb 5, 2025

Closes #5065

Changes

Process edit grid components in the json dump registration backend

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (9894ae6) to head (2c638d2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5081   +/-   ##
=======================================
  Coverage   96.73%   96.74%           
=======================================
  Files         771      771           
  Lines       26619    26636   +17     
  Branches     3463     3467    +4     
=======================================
+ Hits        25751    25770   +19     
+ Misses        606      605    -1     
+ Partials      262      261    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorvanwijk viktorvanwijk force-pushed the bug/5065-attachments-in-a-repeating-group-are-not-processed-in-the-json-dump-registration-backend branch from 5644149 to 22e9720 Compare February 5, 2025 11:30
@viktorvanwijk viktorvanwijk marked this pull request as ready for review February 5, 2025 11:31
The edit grid component was not processed, meaning components (File, Radio, Select, and SelectBoxes) inside the edit grid component were not updated properly. They are now
* Add test for a (multiple) file component inside an edit grid component. Ensures the attachments are properly encoded.
* Add test for components with another form variable as a data source inside an edit grid component. Ensures the options of the radio, select, and selectboxes components are properly updated.
@viktorvanwijk viktorvanwijk force-pushed the bug/5065-attachments-in-a-repeating-group-are-not-processed-in-the-json-dump-registration-backend branch from 22e9720 to 2c638d2 Compare February 6, 2025 14:05
@viktorvanwijk viktorvanwijk merged commit 6d3db22 into master Feb 6, 2025
33 checks passed
@viktorvanwijk viktorvanwijk deleted the bug/5065-attachments-in-a-repeating-group-are-not-processed-in-the-json-dump-registration-backend branch February 6, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachments in a repeating group are not processed in the JSON dump registration backend
2 participants