⏪ Revert removal of DISABLE_SENDING_HIDDEN_FIELDS feature flag #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts #4759. DH is facing challenges with legacy forms while upgrading to 3.0 on a strict timeline. Because the forms haven't been migrated to variables mapping yet, this has a huge impact on downstream systems processing the submissions.
|
I don't know if we have to put this back in master too or not, but it's probably best so these discussions stop from happening every quarter. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable/3.0.x #5083 +/- ##
=============================================
Coverage 96.65% 96.66%
=============================================
Files 761 761
Lines 25984 25993 +9
Branches 3397 3399 +2
=============================================
+ Hits 25116 25125 +9
Misses 602 602
Partials 266 266 ☔ View full report in Codecov by Sentry. |
sergei-maertens
deleted the
revert/4759-un-remove-disable-hidden-feature-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4759.
DH is facing challenges with legacy forms while upgrading to 3.0 on a strict timeline. Because the forms haven't been migrated to variables mapping yet, this has a huge impact on downstream systems processing the submissions.