-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glossary item for "pull" #65
Conversation
I would like it if there would be something about the fact, that the GitOps agent needs to be able to access the SSoT at any time. Maybe we add the following sentence? In contrast to traditional, CI/CD pipelines which "push" event based triggers to discover state changes, in GitOps desired state is "pulled". The GitOps agents need to be able to access the desired state at any time to avoid drifts. This state may be reconciled with local or remote actual states. In GitOps agents are expected to pull both desired and actual states without the requirement of events. Webhooks may be used to speed up this process, but should a webhook fail, the agent is still expected to discover changes to desired state by pulling from the source of truth. |
Thanks @todaywasawesome for hopping on this. @ubaumann I agree, from Slack and elaborated in this discussion answer open-gitops/project#134 (comment) WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dan what do you think about this? building on what you wrote but also with more direct ties to existing content. If so you can merge this suggestion into your PR branch directly (number 3 in Incorporating feedback in your pull request).
Great 👍 Now just looks like DCO bot is unhappy with email mismatch:
Steps to fix: https://github.com/open-gitops/documents/runs/12166015365 |
Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]>
Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Dan Garfield <[email protected]>
984ed8e
to
988845c
Compare
Signed-off-by: Dan Garfield <[email protected]>
@todaywasawesome Looks good to me! It makes it much more straightforward. Thanks |
After merging this, we can create a v1.1.0 draft similar to how we did 1.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok this has been open for review in its current state for a good while now, has multiple collaborators/co-authors, and 4 maintainer approvals. Merging. Thanks everyone! 🚀 |
Signed-off-by: Scott Rigby <[email protected]>
From this discussion: open-gitops/project#134
Signed-off-by: Dan Garfield [email protected]
Signed-off-by: Dan Garfield [email protected]