Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jak2: add missing pc options to progress menu #3167

Merged
merged 21 commits into from
Nov 9, 2023
Merged

jak2: add missing pc options to progress menu #3167

merged 21 commits into from
Nov 9, 2023

Conversation

Hat-Kid
Copy link
Member

@Hat-Kid Hat-Kid commented Nov 6, 2023 •
edited
Loading

Adds the majority of the missing PC options to the progress menu, such as most of the graphics options, camera options and a quit game button on the title screen menu.

Fixes #3116

image
image

@xTVaser xTVaser mentioned this pull request Nov 6, 2023
Closed
2 tasks
ManDude
ManDude requested changes Nov 6, 2023
View reviewed changes
goal_src/jak2/pc/progress/progress-static-pc.gc Outdated Show resolved Hide resolved
goal_src/jak2/pc/progress/progress-static-pc.gc Outdated Show resolved Hide resolved
@dallmeyer dallmeyer mentioned this pull request Nov 8, 2023
Closed
2 tasks
xTVaser
xTVaser approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@xTVaser xTVaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled it down and tested the major things -- if graphics options save / if the camera changes work. They did

ManDude
ManDude requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ManDude ManDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing - the "quit game" text is flashing instead of white when the option is selected.

@Hat-Kid Hat-Kid merged commit b2453fe into open-goal:master Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xTVaser xTVaser xTVaser approved these changes

@ManDude ManDude ManDude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Main Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Left/Right (3rd Person) is Inverted Permanently
3 participants
@Hat-Kid @ManDude @xTVaser