989snd: sound bank loading overhaul #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziemas
force-pushed
the
sound-stuff
branch
5 times, most recently
from
66099b8 to
b855490
Compare
fread into struct is annoying and limiting
Ziemas
changed the title
|
Isn't Edit: I'm dumb, nevermind. |
Ziemas
force-pushed
the
sound-stuff
branch
2 times, most recently
from
79ff56b to
0d83e60
Compare
xTVaser
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the mistake of trying to rewrite all of the 989snd code in one go and quickly lost motivation. Starting to bring over the stuff that was actually done.
This is very likely still buggy, so needs testing and work.
Should probably fix #1417