Update to C++20 #3193
Merged
Update to C++20 #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziemas
force-pushed
the
cpp20
branch
2 times, most recently
from
3d8979c to
8d38c34
Compare
xTVaser
reviewed
Jan 4, 2024
CMakeLists.txt
Outdated
| @@ -189,7 +188,6 @@ include_directories(SYSTEM third-party/inja) | |||
| # Enable SSL Support, most URLs now-a-days use SSL! | |||
| # TODO - probably integrate with ZSTD since we have it already | |||
| set(CURL_USE_LIBSSH2 OFF) | |||
| set(CURL_ZLIB OFF) | |||
There was a problem hiding this comment.
curious if you found a reason this wasn't needed, I unfortunately can't remember if I had a good reason why I added it -- but i know it was when i was troubleshooting why the binaries were expecting some libraries to be dynamically linked
There was a problem hiding this comment.
I was getting linker errors with this option set. But I can't reproduce them now 🤔
Mostly just tagging stuff for runtime formatting
Not permitted in c++20
in c++20 these are not compatible with normal string
…use dynamic linking errors on next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just putting this here for consideration, I'm personally not in a big rush to get it.