Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: transcribe missing english subtitles #3199

Merged
merged 20 commits into from
Nov 18, 2023

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Nov 12, 2023

Working through transcribing the remaining subtitle lines into English, I will then add them to Crowdin.

Issues noticed with the subtitle editor as I do this:

  • deleting a non-cutscene after making it is a crash
  • saving a new cutscene doesnt play properly (or atleast consistently), function that runs it returns #f
  • making a new scene and selecting it doesnt populate the "currently selected scene" label properly
  • circle does not reset a voice line like the UI implies
  • it'd be nice when clicking "add text entry" if it updated your old starting frame to your old ending frame (for the next line) similarly, when changing scenes if the fields reset (leaving speaker alone is good though). Separate buttons for these are likely required.
  • selecting Samos for some reason doesn't want to switch speakers

@xTVaser xTVaser marked this pull request as ready for review November 14, 2023 01:00
@xTVaser xTVaser force-pushed the v/transribe-subtitles branch from 19dda33 to bbbb1ee Compare November 15, 2023 00:15
@xTVaser xTVaser merged commit 014cbb0 into open-goal:master Nov 18, 2023
9 checks passed
@xTVaser xTVaser deleted the v/transribe-subtitles branch November 18, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants