Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #30

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update README.md #30

merged 1 commit into from
Mar 5, 2024

Conversation

tmsdkeys
Copy link
Contributor

@tmsdkeys tmsdkeys commented Mar 5, 2024

Summary by CodeRabbit

  • Documentation
    • Updated the README to remove outdated information regarding the Polymer IBC explorer.

Copy link
Contributor

coderabbitai bot commented Mar 5, 2024

Walkthrough

The update involves a simplification of the documentation, specifically within the README.md file. A reference to checking packets on the Polymer IBC explorer has been removed, streamlining the information provided to users and possibly reflecting a change in how users are expected to interact with or verify packet information.

Changes

File(s) Change Summary
README.md Removed reference to checking packets on Polymer IBC explorer

🐰✨
In the realm of code, where rabbits dare to hop,
A tiny change unfolds, a reference we drop.
No more a guide to packets, in explorers far and wide,
Simplify, we must, as through docs we glide.
Let's hop to clarity, with every leap and bound,
In README lands, where understanding is found.
🌟📜

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tmsdkeys tmsdkeys merged commit 564c17d into main Mar 5, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 29

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ce364a3 and efb97a4.
Files selected for processing (1)
  • README.md (1 hunks)
Additional comments: 1
README.md (1)
  • 101-106: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [74-74]

The repeated word "do-it" in the command usage example might be a typo. Please verify if this repetition is intentional.

Comment on lines 101 to 106

<!-- TODO: add how to check for the packet on explorer or set up an event listener -->

Check if the packet got through on the [Polymer IBC explorer](https://explorer.prod.testnet.polymer.zone/packets).

## 💻 Develop your custom application

The main work for you as a developer is to develop the contracts that make up your cross-chain logic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [3-3]

Consider revising "rollups to one another Polymer Hub" to "rollups to the Polymer Hub" for clarity and to correct the possible spelling mistake.

- rollups to one another Polymer Hub
+ rollups to the Polymer Hub

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [5-5]

A comma might enhance readability after "repository" in the sentence starting with "The repository is a GitHub template repository".

- The repository is a _GitHub template_ repository
+ The repository is a _GitHub template_ repository,

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [11-11]

Consider adding a comma before "but" to connect two independent clauses for improved readability.

- There's some basic information here in the README but a more comprehensive documentation can
+ There's some basic information here in the README, but a more comprehensive documentation can

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [19-19]

The abbreviation "npm" is more commonly used in lowercase. Consider revising for consistency with common practices.

- (Hardhat will be installed when running `npm install`)
+ (Hardhat will be installed when running `npm install`)

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [23-23]

The term "third party's" seems to be incorrectly used. If referring to multiple third parties, consider revising to "third parties'".

- You'll need some API keys from third party's:
+ You'll need some API keys from third parties':

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [32-32]

A comma after "directory" could improve the flow of the sentence.

- From the root directory run:
+ From the root directory, run:

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [37-37]

The sentence starting with "to install the [vIBC core smart contracts]" should begin with an uppercase letter for consistency.

- to install the [vIBC core smart contracts]
+ To install the [vIBC core smart contracts]

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [39-39]

Consider adding a comma after "Additionally" for clarity.

- Additionally Hardhat will be installed as a dev dependency
+ Additionally, Hardhat will be installed as a dev dependency

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [44-44]

A comma after "commits" could improve the readability of the sentence.

- This will ignore the file for future git commits as well as expose the environment variables
+ This will ignore the file for future git commits, as well as expose the environment variables

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [50-50]

The term "justfile" is typically written as "Justfile". Consider revising for consistency with common naming conventions.

- the scripts from the justfile will fail.
+ the scripts from the Justfile will fail.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [59-59]

Consider revising "Quickstart" to "Quick Start" for consistency with common terminology.

- ## 🏃🏽🏃🏻‍♀️ Quickstart
+ ## 🏃🏽🏃🏻‍♀️ Quick Start

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [65-65]

The file extension ".json" in "config.json" is typically written in lowercase. Consider revising for consistency.

- The default setup (`.env`, `config.json`)
+ The default setup (`.env`, `config.json`)

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [89-89]

Consider adding a comma before "BUT" for clarity and grammatical correctness.

- useful for iterative development and testing BUT also insecure
+ useful for iterative development and testing, BUT also insecure

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [114-114]

The term "Justfile" is typically capitalized. Consider revising for consistency with common naming conventions.

- There is a Justfile to for the most common commands
+ There is a Justfile for the most common commands

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [115-115]

Consider revising "There's three types" to "There are three types" for grammatical correctness.

- There's three types of default scripts in the project:
+ There are three types of default scripts in the project:

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [122-122]

A comma after "script" could improve the readability of the sentence.

- For every script you'll find a field in the configuration file
+ For every script, you'll find a field in the configuration file

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [124-124]

Consider adding a comma after "cases" for clarity.

- For more complicated use cases you will want to customize the scripts
+ For more complicated use cases, you will want to customize the scripts

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [136-136]

The sentence starting with "to deploy MyContract artefact" should begin with an uppercase letter for consistency.

- to deploy _MyContract_ artefact to the Optimism (Sepolia) chain.
+ To deploy _MyContract_ artefact to the Optimism (Sepolia) chain.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [137-137]

Consider revising "artefact" to "artifact" for American English consistency.

- to deploy _MyContract_ artefact to the Optimism (Sepolia) chain.
+ to deploy _MyContract_ artifact to the Optimism (Sepolia) chain.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [152-152]

The sentence starting with "for an application that uses custom channels" should begin with an uppercase letter for consistency.

- for an application that uses custom channels.
+ For an application that uses custom channels.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [168-168]

A comma after "contract" could improve the readability of the sentence.

- Your contract will send and receive packet data from the Universal channel handler contract
+ Your contract will send and receive packet data from the Universal channel handler contract,

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [190-190]

The sentence starting with "to send a packet over a universal channel" should begin with an uppercase letter for consistency.

- to send a packet over a **universal channel**.
+ To send a packet over a **universal channel**.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [198-198]

The sentence starting with "to send a packet over a custom channel" should begin with an uppercase letter for consistency.

- to send a packet over a **custom channel**.
+ To send a packet over a **custom channel**.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [203-203]

Consider adding a comma before "BUT" for clarity and grammatical correctness.

- useful for iterative development and testing BUT also insecure
+ useful for iterative development and testing, BUT also insecure

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [214-214]

Consider revising "custimizations" to "customizations" for spelling accuracy and "These includes" to "These include" for grammatical correctness.

- there's multiple custimizations to follow. These includes configuring
+ there are multiple customizations to follow. These include configuring

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [228-228]

Consider adding a comma before "so" for clarity and grammatical correctness.

- Assign yourself to the issue so people know you're working on it.
+ Assign yourself to the issue, so people know you're working on it.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [229-229]

Consider adding a comma after "Alternatively" for clarity.

- Alternatively you can open an issue for a new idea or piece of feedback.
+ Alternatively, you can open an issue for a new idea or piece of feedback.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [236-236]

Consider adding a comma before "and" for clarity and grammatical correctness.

- submit a PR to the repo and we'll review as soon as possible.
+ submit a PR to the repo, and we'll review as soon as possible.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [239-239]

Consider using a less frequent alternative to "Feel free to" for a more professional tone.

- Feel free to open an issue for questions, suggestions, or discussions related to this repository.
+ You are welcome to open an issue for questions, suggestions, or discussions related to this repository.

@tmsdkeys tmsdkeys deleted the tmsdkeys-patch-1 branch April 12, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant