Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add job to check contract sizes #60

Merged
merged 1 commit into from
Mar 14, 2024
Merged

ci: add job to check contract sizes #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/test.yml → .github/workflows/foundry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Tests
name: Foundry

on:
pull_request:
Expand All @@ -21,5 +21,8 @@ jobs:
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1

- name: Test
- name: Check contract sizes
run: forge build --sizes --deny-warnings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be worth adding forge coverage to the ci as well. right now forge coverage is throwing a compile error, but if we add the line src/=lib/optimism/packages/contracts-bedrock/src/ to remappings.txt file, its hould fix it (looks like it's some bug in the optimism library)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(thanks to @Inkvi for the suggestion)


- name: Tests
run: forge test
Loading