Fix Test Suite Filter (#16615)

Co-authored-by: Sriharsha Chintalapani <[email protected]>
open-metadata · Jun 12, 2024 · 3db41f0 · 3db41f0
1 parent dc31717
commit 3db41f0
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 15 deletions.
diff --git a/bootstrap/sql/migrations/native/1.4.2/mysql/schemaChanges.sql b/bootstrap/sql/migrations/native/1.4.2/mysql/schemaChanges.sql
@@ -1,2 +1,4 @@
 ALTER TABLE ingestion_pipeline_entity ADD COLUMN appType VARCHAR(256) GENERATED ALWAYS AS (json ->> '$.sourceConfig.config.appConfig.type') STORED NULL;
-ALTER TABLE ingestion_pipeline_entity ADD COLUMN pipelineType VARCHAR(256) GENERATED ALWAYS AS (json ->> '$.pipelineType') STORED NULL;
+ALTER TABLE ingestion_pipeline_entity ADD COLUMN pipelineType VARCHAR(256) GENERATED ALWAYS AS (json ->> '$.pipelineType') STORED NULL;
+
+DELETE FROM event_subscription_entity WHERE JSON_UNQUOTE(JSON_EXTRACT(json, '$.filteringRules.resources[0]')) = 'testSuite';
diff --git a/bootstrap/sql/migrations/native/1.4.2/postgres/schemaChanges.sql b/bootstrap/sql/migrations/native/1.4.2/postgres/schemaChanges.sql
@@ -1,2 +1,4 @@
 ALTER TABLE ingestion_pipeline_entity ADD COLUMN appType VARCHAR(256) GENERATED ALWAYS AS (json -> 'sourceConfig' -> 'config' -> 'appConfig' ->> 'type') STORED NULL;
-ALTER TABLE ingestion_pipeline_entity ADD COLUMN pipelineType VARCHAR(256) GENERATED ALWAYS AS (json ->> 'pipelineType') STORED NULL;
+ALTER TABLE ingestion_pipeline_entity ADD COLUMN pipelineType VARCHAR(256) GENERATED ALWAYS AS (json ->> 'pipelineType') STORED NULL;
+
+delete from event_subscription_entity where (json -> 'filteringRules' -> 'resources' ->> 0) = 'testSuite';
diff --git a/openmetadata-service/src/main/resources/json/data/EntityObservabilityFilterDescriptor.json b/openmetadata-service/src/main/resources/json/data/EntityObservabilityFilterDescriptor.json
@@ -338,6 +338,19 @@
           "testResultList"
         ],
         "inputType": "runtime"
+      },
+      {
+        "name": "GetTestCaseStatusUpdatesUnderSuite",
+        "fullyQualifiedName": "eventSubscription.GetTestCaseStatusUpdatesUnderSuite",
+        "displayName": "Get Test Case Status Updates belonging to a Test Suite",
+        "description" : "Get Status Updates Test Cases belonging to a Test Suite",
+        "effect" : "include",
+        "condition": "getTestCaseStatusIfInTestSuite(${testStatusList}, ${testSuiteList})",
+        "arguments": [
+          "testStatusList",
+          "testSuiteList"
+        ],
+        "inputType": "runtime"
       }
     ]
   },
@@ -382,19 +395,6 @@
       }
     ],
     "supportedActions" : [
-      {
-        "name": "GetTestCaseStatusUpdatesUnderSuite",
-        "fullyQualifiedName": "eventSubscription.GetTestCaseStatusUpdatesUnderSuite",
-        "displayName": "Get Test Case Status Updates belonging to a Test Suite",
-        "description" : "Get Status Updates Test Cases belonging to a Test Suite",
-        "effect" : "include",
-        "condition": "getTestCaseStatusIfInTestSuite(${testStatusList}, ${testSuiteList})",
-        "arguments": [
-          "testStatusList",
-          "testSuiteList"
-        ],
-        "inputType": "runtime"
-      }
     ]
   }
 ]