Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test case of Add Data Product Modal #15360

Merged

Conversation

harsh-vador
Copy link
Contributor

Describe your changes:

I worked on adding unit test case of Add Data Product Modal.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani chirag-madlani added the safe to test Add this label to run secure Github workflows on PRs label Feb 27, 2024
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.16% (31808/51172) 40.51% (12488/30829) 41.31% (3897/9434)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

cypress bot commented Feb 27, 2024

12 failed tests on run #33214 ↗︎

12 0 720 0 Flakiness 0

Details:

test: unit test case of Add Data Product Modal
Project: openmetadata Commit: 8ad03d6815
Status: Failed Duration: 06:44 💡
Started: Feb 27, 2024 9:47 AM Ended: Feb 27, 2024 9:53 AM
Failed  Pages/EntityVersionPages.spec.js • 7 failed tests • cypress-ci-mysql-pr-8062474651-1

View Output Video

Test Artifacts
Version page tests for data assets > Table version page should work properly > Table version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Topic version page should work properly > Topic version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Dashboard version page should work properly > Dashboard version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Pipeline version page should work properly > Pipeline version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > ML Model version page should work properly > ML Model version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Container version page should work properly > Container version page should show changes after soft deleted Screenshots Video
Version page tests for data assets > Search Index version page should work properly > Search Index version page should show changes after soft deleted Screenshots Video
Failed  Flow/SearchFlow.spec.js • 3 failed tests • cypress-ci-mysql-pr-8062474651-1

View Output Video

Test Artifacts
Advance search > Single filed search > Verify advance search results for Column field and all condition Screenshots Video
Advance search > Group search > Verify Add group functionality for All with OR operator & condition Contains and Not contains Screenshots Video
Advance search > Search with additional rule > Verify Add Rule functionality for All with OR operator & condition Contains and Not contains Screenshots Video
Failed  Pages/Glossary.spec.js • 1 failed test • cypress-ci-mysql-pr-8062474651-1

View Output Video

Test Artifacts
Glossary page should work properly > Delete glossary should work properly Screenshots Video
Failed  Flow/CustomizeLandingPage.spec.js • 1 failed test • cypress-ci-mysql-pr-8062474651-1

View Output Video

Test Artifacts
Customize Landing Page Flow > Resetting the layout flow should work properly Screenshots Video

Review all test suite changes for PR #15360 ↗︎

@chirag-madlani chirag-madlani merged commit e755267 into open-metadata:main Feb 28, 2024
18 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants