[FIX] Fixes Poll Interval for App Jobs, and fixed Search Indexing Stats #15453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
safe to test
10 failed tests on run #33336 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Teams flow should work properly > Update description for created team |
Screenshots
Video
|
|
Pages/Policies.spec.js • 2 failed tests • cypress-ci-mysql-pr-8160958089-1
| Test | Artifacts | |
|---|---|---|
| Policy page should work properly > Add new policy |
Screenshots
Video
|
|
| Policy page should work properly > Edit policy description |
Screenshots
Video
|
|
Pages/Roles.spec.js • 2 failed tests • cypress-ci-mysql-pr-8160958089-1
| Test | Artifacts | |
|---|---|---|
| Roles page should work properly > Add new role and check all tabs data |
Screenshots
Video
|
|
| Roles page should work properly > Edit created role |
Screenshots
Video
|
|
Flow/AddRoleAndAssignToUser.spec.js • 1 failed test • cypress-ci-mysql-pr-8160958089-1
| Test | Artifacts | |
|---|---|---|
| Test Add role and assign it to the user > Create role |
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.
Review all test suite changes for PR #15453 ↗︎
- Disable Tests for Subscription for Query
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
harshach
reviewed
Mar 5, 2024
openmetadata-service/src/test/java/org/openmetadata/service/resources/EntityResourceTest.java
Outdated
Show resolved
Hide resolved
- On update remove already init instance
harshach
reviewed
Mar 5, 2024
| @@ -77,13 +64,9 @@ public static void runMethodFromApplication( | |||
| | IllegalAccessException | |||
| | InvocationTargetException e) { | |||
| LOG.error("Exception encountered", e); | |||
| throw new UnhandledServerException("Exception encountered", e); | |||
| throw new UnhandledServerException(e.getCause().getMessage()); | |||
There was a problem hiding this comment.
@mohityadav766 lets not throw the message here, we should provide clear api response
harshach
approved these changes
Mar 5, 2024
mohityadav766
added a commit
that referenced
this pull request
Mar 5, 2024
* - Fix Poll Interval * make poll interval as 1 * - Add random tests - Disable Tests for Subscription for Query * - Checkstyle Fix * - Remove ondemand jobs as well - On update remove already init instance * - use alias * - typo * - Search Index Fix (cherry picked from commit 9491e04)
|
mohityadav766
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>