Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR - Application Handler instance #15482

Merged
merged 4 commits into from
Mar 7, 2024
Merged

MINOR - Application Handler instance #15482

merged 4 commits into from
Mar 7, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Mar 7, 2024 •
edited
Loading

Describe your changes:

Since we reverted the app instances cache, we need still a way to initialize the app with runtime props

Also removing some old docs

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner March 7, 2024 08:27
@github-actions github-actions bot added documentation Improvements or additions to documentation backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Mar 7, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Mar 7, 2024

13 failed tests on run #33356 ↗︎

13 721 12 0 Flakiness 0

Details:

MINOR - AppHandler instance
Project: openmetadata Commit: c40914def8
Status: Failed Duration: 17:37 💡
Started: Mar 7, 2024 8:47 AM Ended: Mar 7, 2024 10:05 AM
Failed  Glossary.spec.js • 7 failed tests • cypress-ci-mysql-pr-8185106505-1

View Output Video

Test Artifacts
Glossary page should work properly > Approval Workflow for Glossary Term Screenshots Video
Glossary page should work properly > Update glossary term Screenshots Video
Glossary page should work properly > Request Tags workflow for Glossary Screenshots Video
Glossary page should work properly > Assets Tab should work properly Screenshots Video
Glossary page should work properly > Remove Glossary term from entity should work properly Screenshots Video
Glossary page should work properly > Delete glossary term should work properly Screenshots Video
Glossary page should work properly > Delete glossary should work properly Screenshots Video
Failed  Customproperties.spec.js • 1 failed test • cypress-ci-mysql-pr-8185106505-1

View Output Video

Test Artifacts
Custom Properties should work properly > Custom properties for glossary and glossary terms > Add update and delete String, Integer, Markdown custom properties for glossary term Screenshots Video
Failed  Domains.spec.js • 1 failed test • cypress-ci-mysql-pr-8185106505-1

View Output Video

Test Artifacts
Domain page should work properly > Remove Domain from entity should work properly Screenshots Video
Failed  Teams.spec.js • 1 failed test • cypress-ci-mysql-pr-8185106505-1

View Output Video

Test Artifacts
Teams flow should work properly > Update description for created team Screenshots Video
Failed  GlossaryVersionPage.spec.js • 1 failed test • cypress-ci-mysql-pr-8185106505-1

View Output Video

Test Artifacts
Glossary and glossary term version pages should work properly > Glossary term version page should display owner and reviewer changes properly Screenshots Video

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

Review all test suite changes for PR #15482 ↗︎

@pmbrull pmbrull merged commit 1a3ba7f into open-metadata:main Mar 7, 2024
26 of 30 checks passed
@pmbrull pmbrull deleted the app-init-handler branch March 7, 2024 11:24
pmbrull added a commit that referenced this pull request Mar 21, 2024
@pmbrull
MINOR - Application Handler instance (#15482)
0cf2b48 
* Clean docs

* MINOR - AppHandler instance

* MINOR - AppHandler instance

* MINOR - AppHandler instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmbrull @mohityadav766