playwright: initial setup of playwright for UI #16419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
ShaileshParmar11
requested review from
chirag-madlani and
Sachin-chaurasiya
as code owners
github-actions
bot
added
devops
e2e:Governance
e2e:DataAssets
and removed
devops
labels
Comment on lines
46
to
47
| echo "CYPRESS_PROJECT_ID=${{ secrets.CYPRESS_PR_PROJECT_ID }}" >> $GITHUB_OUTPUT | ||
| echo "CYPRESS_RECORD_KEY=${{ secrets.CYPRESS_PR_RECORD_KEY }}" >> $GITHUB_OUTPUT |
Comment on lines
+130
to
+136
| CYPRESS_BASE_URL: "http://localhost:8585" | ||
| CYPRESS_RECORD_KEY: ${{ steps.cypress-project-id.outputs.CYPRESS_RECORD_KEY }} | ||
| CYPRESS_grepTags: ${{ steps.getCypresse2eLabels.outputs.e2eLabels }} | ||
| CYPRESS_grepFilterSpecs: "true" | ||
| CYPRESS_SNOWFLAKE_USERNAME: ${{ secrets.TEST_SNOWFLAKE_USERNAME }} | ||
| CYPRESS_SNOWFLAKE_PASSWORD: ${{ secrets.TEST_SNOWFLAKE_PASSWORD }} | ||
| CYPRESS_SNOWFLAKE_ACCOUNT: ${{ secrets.TEST_SNOWFLAKE_ACCOUNT }} |
There was a problem hiding this comment.
Let's remove this variable if we are not using it for playwright
There was a problem hiding this comment.
we have kept env variable in the workflow intentionally as we will need in serviceIngetion test once we migrate it to playwright
| with: | ||
| name: playwright-report | ||
| path: openmetadata-ui/src/main/resources/ui/playwright/output/playwright-report | ||
| retention-days: 30 |
There was a problem hiding this comment.
Let'e reduce it to 5 days
| "@deuex-solutions/react-tour": "^1.2.6", | ||
| "@estruyf/github-actions-reporter": "^1.7.0", |
There was a problem hiding this comment.
Don't think we need this package, It's for CI only
Comment on lines
2
to
8
| * Copyright 2024 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, |
There was a problem hiding this comment.
If nothing here, let's remove it
|
akash-jain-10
approved these changes
May 31, 2024
chirag-madlani
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Add the playwright initial setup
below entity are migrated from cypress to playwright
added below assertions
Run Playwright in the terminal with the below command from UI directory
Run Playwright with GUI with the below command from UI directory