Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes : 14333 - Changed announcements startTime and endTime from seconds to milliseconds. #16438

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Fixes : 14333 - Changed announcements startTime and endTime from seconds to milliseconds. #16438

merged 8 commits into from
Jun 3, 2024

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented May 28, 2024 •
edited by Ashish8689
Loading

Fixes #14333

  • Convert startTime and endTime in milliseconds for the announcements.
Screen.Recording.2024-05-30.at.5.38.54.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline requested a review from a team as a code owner May 28, 2024 10:13
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@sonika-shah sonika-shah added the safe to test Add this label to run secure Github workflows on PRs label May 28, 2024
@mohityadav766
Copy link
Contributor

@chirag-madlani can you confirm if this needs any handling on the UI?

mohityadav766
mohityadav766 previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@mohityadav766 mohityadav766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good @Siddhanttimeline , please make sure to test the migrations

@chirag-madlani
Copy link
Collaborator

@chirag-madlani can you confirm if this needs any handling on the UI?

Yes it will some ui changes. I will take a look here tomorrow

@Siddhanttimeline
Copy link
Contributor Author

Changes looks good @Siddhanttimeline , please make sure to test the migrations

okay, I will check and confirm.

@Ashish8689
Copy link
Contributor

@mohityadav766 @Siddhanttimeline I will have a look at the UI side changes and let you all know once done!

@Siddhanttimeline
Copy link
Contributor Author

okay, I will check and confirm.

Migrations are confirmed to be working fine for MySQL and PostgreSQL.

mohityadav766
mohityadav766 previously approved these changes May 30, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.93% (34898/53743) 41.87% (13818/32999) 43.76% (4283/9787)

@cypress Cypress
Copy link

cypress bot commented May 30, 2024 •
edited
Loading

4 failed tests on run #34297 ↗︎

4 293 8 35 Flakiness 0

Details:

Merge branch 'main' into Improvements-announcement
Project: openmetadata Commit: e548041190
Status: Failed Duration: 29:05 💡
Started: Jun 3, 2024 7:28 AM Ended: Jun 3, 2024 7:57 AM
Failed  Pages/Database.spec.ts • 3 failed tests • cypress-ci-mysql-pr-9345803006-1

View Output Video

Test Artifacts
Database hierarchy details page > Table page > Soft delete Screenshots Video
Database hierarchy details page > Table page > Hard delete Screenshots Video
Database hierarchy details page > Store Procedure page > Domain assign, update & delete Screenshots Video
Failed  Flow/Lineage.spec.ts • 1 failed test • cypress-ci-mysql-pr-9345803006-1

View Output Video

Test Artifacts
Lineage verification > Add column lineage Screenshots Video

Review all test suite changes for PR #16438 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit 7558ccc into open-metadata:main Jun 3, 2024
22 of 24 checks passed
@Siddhanttimeline Siddhanttimeline deleted the Improvements-announcement branch June 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Announcement startTime and endTime should be in milliseconds instead of seconds
5 participants
@Siddhanttimeline @mohityadav766 @chirag-madlani @Ashish8689 @sonika-shah