Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: remove unnecessary repository calls in SearchRepository #17579

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

harshach
Copy link
Collaborator

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner August 24, 2024 04:20
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Aug 24, 2024
Copy link

Copy link

cypress bot commented Aug 24, 2024

openmetadata    Run #34889

Run Properties:  status check failed Failed #34889  •  git commit a7e8a55bbc: Minor: remove unnecessary repository calls in SaerchRepository
Project openmetadata
Branch Review remove_unnecessary_invocations
Run status status check failed Failed #34889
Run duration 54m 06s
Commit git commit a7e8a55bbc: Minor: remove unnecessary repository calls in SaerchRepository
Committer Sriharsha Chintalapani
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 335
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/Pages/Glossary.spec.ts • 1 failed test • cypress-ci-mysql-pr-10536445815-1

View Output Video

Test Artifacts
Glossary page should work properly > Remove Glossary term from entity should work properly Screenshots Video

@harshach harshach changed the title Minor: remove unnecessary repository calls in SaerchRepository Minor: remove unnecessary repository calls in SearchRepository Aug 26, 2024
@harshach harshach merged commit ee11760 into main Sep 1, 2024
30 of 32 checks passed
@harshach harshach deleted the remove_unnecessary_invocations branch September 1, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants