Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fixed AUT failure #17607

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Minor: Fixed AUT failure #17607

merged 2 commits into from
Aug 28, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Aug 28, 2024 •
edited
Loading

fixed Minor AUT failure

  • DBT
  • Data insight application

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Integration e2e:Observability safe to test Add this label to run secure Github workflows on PRs labels Aug 28, 2024
@ShaileshParmar11 ShaileshParmar11 added the e2e This will trigger e2e test workflows label Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.09% (37138/57059) 41.57% (14752/35489) 43.92% (4524/10300)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Aug 28, 2024

openmetadata    Run #34903

Run Properties:  status check passed Passed #34903  •  git commit bf5ddfff17: minor test fix for DBT
Project openmetadata
Branch Review data-insight-app-timeout
Run status status check passed Passed #34903
Run duration 27m 39s
Commit git commit bf5ddfff17: minor test fix for DBT
Committer Shailesh Parmar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 129
View all changes introduced in this branch ↗︎

@ShaileshParmar11 ShaileshParmar11 merged commit 4c354ea into main Aug 28, 2024
26 of 31 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the data-insight-app-timeout branch August 28, 2024 08:58
Sachin-chaurasiya pushed a commit that referenced this pull request Aug 30, 2024
@ShaileshParmar11 @Sachin-chaurasiya
Minor: Fixed AUT failure (#17607)
b99078f 
* Minor: update timeout for AUT in DI application

* minor test fix for DBT

(cherry picked from commit 4c354ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees
No one assigned
Labels
e2e:Integration e2e:Observability e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @Sachin-chaurasiya