fix(ui): pick email and name based on claim values at time of login #17626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-madlani
requested review from
ShaileshParmar11,
karanh37 and
Sachin-chaurasiya
as code owners
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
ShaileshParmar11
previously approved these changes
Aug 29, 2024
karanh37
previously approved these changes
Aug 29, 2024
ShaileshParmar11
approved these changes
Aug 30, 2024
|
|
mohityadav766
approved these changes
Aug 30, 2024
chirag-madlani
added a commit
that referenced
this pull request
Aug 30, 2024
…17626) * fix(ui): pick email and name based on claim values at time of login * Update Error Message * Update code for better message * Typo * fix playwright failures * fix playwright tests * fix tests * fix login spec failing --------- Co-authored-by: mohitdeuex <[email protected]> (cherry picked from commit fa3529f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes: Azure login issue with preferred_username as claim for initial admins
362586579-36834193-3007-437b-b9c2-5b1c2a0c89ca.mov
362586523-9d8bd397-7932-4478-8c49-abbe29276910.mov
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>