Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector: vertexai schema #17632

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

harshsoni2024
Copy link
Contributor

@harshsoni2024 harshsoni2024 commented Aug 29, 2024

Describe your changes:

Fixes

I worked on vertexai connection schema

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

ulixius9
ulixius9 previously approved these changes Aug 29, 2024
@@ -0,0 +1,33 @@
source:
type: vertexai
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the YAML from here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we put it in collate repo?

Copy link

@harshach harshach merged commit 5393e5e into open-metadata:main Aug 30, 2024
18 of 19 checks passed
harshsoni2024 added a commit to harshsoni2024/OpenMetadata that referenced this pull request Sep 4, 2024
* vertexai connection schema

* remove yaml file
@harshsoni2024 harshsoni2024 deleted the vertexai_schema branch December 19, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants