Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: fixed styling issue for DQ #17651

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Minor: fixed styling issue for DQ #17651

merged 1 commit into from
Aug 30, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Aug 30, 2024 •
edited
Loading

Describe your changes:

  • Added search support in column fields
Screen.Recording.2024-08-30.at.7.33.26.PM.mov
Screen.Recording.2024-08-30.at.7.34.01.PM.mov
  • Fixed dropdown overlapping on button issue
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Aug 30, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.11% (37171/57093) 41.57% (14774/35542) 43.92% (4525/10303)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) August 30, 2024 14:37
@ShaileshParmar11 ShaileshParmar11 merged commit d0846d6 into main Aug 30, 2024
19 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the search-support-test-case branch August 30, 2024 15:03
ShaileshParmar11 added a commit that referenced this pull request Aug 30, 2024
@ShaileshParmar11
Minor: fixed styling issue for DQ (#17651)
34f94b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@karanh37 karanh37 karanh37 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaileshParmar11 @chirag-madlani @karanh37 @Sachin-chaurasiya