Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor(ui): migrate AddRoleAndAssignToUser.spec #17670

Merged
merged 4 commits into from
Sep 4, 2024
Merged

minor(ui): migrate AddRoleAndAssignToUser.spec #17670

merged 4 commits into from
Sep 4, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Sep 2, 2024 •
edited
Loading

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.11% (37175/57099) 41.56% (14779/35559) 43.91% (4524/10302)

@chirag-madlani chirag-madlani changed the title Pw migrate add role minor(ui): migrate AddRoleAndAssignToUser.spec Sep 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani enabled auto-merge (squash) September 3, 2024 05:50
@chirag-madlani chirag-madlani merged commit 35bed71 into main Sep 4, 2024
16 of 17 checks passed
@chirag-madlani chirag-madlani deleted the pw-migrate-add-role branch September 4, 2024 15:06
ShaileshParmar11 pushed a commit that referenced this pull request Sep 10, 2024
@chirag-madlani @ShaileshParmar11
minor(ui): migrate AddRoleAndAssignToUser.spec (#17670)
f01f250 
* minor(ui): migrate AddRoleAndAssignToUser.spec

* migrate SchemaDefinition

* revert vite changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @ShaileshParmar11