Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix user spec flaky playwright test #17684

Merged
merged 9 commits into from
Sep 5, 2024
Merged

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Sep 3, 2024

Describe your changes:

Fixes

  • I worked on fixing user spec flaky playwright test
  • fix the bot spec playwright failure

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.11% (37175/57097) 41.57% (14779/35553) 43.91% (4524/10302)

Copy link

sonarqubecloud bot commented Sep 4, 2024

@ShaileshParmar11 ShaileshParmar11 merged commit f846a8a into main Sep 5, 2024
17 of 19 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the user-playwright-fix branch September 5, 2024 05:57
hurongliang added a commit to hurongliang/OpenMetadata that referenced this pull request Sep 6, 2024
* main: (39 commits)
  MINOR - Better PII classification for JSON data (open-metadata#17734)
  New Email Templates (OSS) (open-metadata#17606)
  fix pom. (open-metadata#17682)
  GEN-1333 Add TS validation on DQ and Porfiler data ingestion (open-metadata#17731)
  make cost analysis as collate only (open-metadata#17719)
  Minor: remove unused dependency (open-metadata#17709)
  test: migrate login config to playwright (open-metadata#17740)
  minor(test): fix ingestion related flaky for aut (open-metadata#17727)
  fix expand all operation on terms page (open-metadata#17733)
  Docs: Updating the Image Reference for Bots (open-metadata#17736)
  fix ui freezing due to images in feed changes (open-metadata#17703)
  add links to menus (open-metadata#17659)
  supported followed data in Following widget using search api (open-metadata#17689)
  minor(ui): align dependency version to fix vulnerabilities (open-metadata#17729)
  Fixes some things on the APICollection (open-metadata#17704)
  DOCS - OSS deployment is flagged as Collate False (open-metadata#17722)
  minor: disable image upload support in description editor (open-metadata#17697)
  fix user spec flaky playwright test (open-metadata#17684)
  fetch domains before any widget is loaded (open-metadata#17695)
  minor(test): migrate persona spec (open-metadata#17701)
  ...
Ashish8689 added a commit that referenced this pull request Sep 11, 2024
* fix user spec flaky playwright test

* fix bot spec failure

* fix glossary and version spec failure due to id change in the PR

* fixed queryEntity spec

---------

Co-authored-by: Shailesh Parmar <[email protected]>
Co-authored-by: Chirag Madlani <[email protected]>
(cherry picked from commit f846a8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants