Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async apis for csv import #18647

Merged
merged 21 commits into from
Nov 24, 2024
Merged

Add async apis for csv import #18647

merged 21 commits into from
Nov 24, 2024

Conversation

sonika-shah
Copy link
Contributor

@sonika-shah sonika-shah commented Nov 14, 2024

Describe your changes:

Added the async support for import assets.

GLOSSARY_IMPORT.mov

Type of change:

  • Improvement
  • New feature

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

# Conflicts:
#	openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java
#	openmetadata-service/src/main/java/org/openmetadata/service/util/WebsocketNotificationHandler.java
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

Copy link

@chirag-madlani chirag-madlani merged commit 0e41609 into main Nov 24, 2024
22 of 26 checks passed
@chirag-madlani chirag-madlani deleted the import-csv-async branch November 24, 2024 08:00
harshach added a commit that referenced this pull request Nov 25, 2024
sonika-shah added a commit that referenced this pull request Nov 25, 2024
* Add async apis for import csv

* checkstyle fix

* fix checkstyle after merge from main

* fix auts

* fix backend tests

* ui: add async import support for glossary

* ui: improve the import page layout

* ui: add async import support for teams and users

* show banner at the top

* fix unit test

* update importteams page test

* minor change

---------

Co-authored-by: Sachin Chaurasiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants