Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix the maven build on main #18692

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Minor: Fix the maven build on main #18692

merged 1 commit into from
Nov 19, 2024

Conversation

aniketkatkar97
Copy link
Member

I worked on fixing the maven build on main by adding the missing pipeline type in the localization key mapping object

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 self-assigned this Nov 19, 2024
@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Nov 19, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.57% (39788/62593) 40.19% (15796/39307) 42.33% (4723/11158)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aniketkatkar97 aniketkatkar97 merged commit c30d851 into main Nov 19, 2024
20 of 29 checks passed
@aniketkatkar97 aniketkatkar97 deleted the fix-maven-main branch November 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@pmbrull pmbrull pmbrull approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@aniketkatkar97 aniketkatkar97

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aniketkatkar97 @chirag-madlani @pmbrull @ShaileshParmar11