Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fix missing check on set entity certification #18713

Merged
merged 1 commit into from
Nov 20, 2024
Merged

MINOR: Fix missing check on set entity certification #18713

merged 1 commit into from
Nov 20, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Nov 20, 2024

Adding missing check to the set entity certification implementation

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@IceS2 IceS2 requested a review from a team as a code owner November 20, 2024 15:32
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 20, 2024
@pmbrull pmbrull merged commit 890a4f8 into main Nov 20, 2024
14 of 17 checks passed
@pmbrull pmbrull deleted the fix-certification-logic branch November 20, 2024 18:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

harshach pushed a commit that referenced this pull request Nov 24, 2024
@IceS2 @harshach
Fix missing check on set entity certification (#18713)
e72ac64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IceS2 @pmbrull