Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Governance Workflows fixes #18744

Merged
merged 3 commits into from
Nov 24, 2024
Merged

MINOR: Governance Workflows fixes #18744

merged 3 commits into from
Nov 24, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Nov 22, 2024

Test Fix

The Glossary Term Tests have been a flaky lately and it seems that the delete_recursive test was being running before the end and impacting a some of the terms that were created by other tests that had not finished yet.

For this reason I added an annotation to guarantee the test would be the last one to run.

Performance Improvement

In order to improve the performance of the Certification Workflow, we are changing the Entity Fetch method to get only the FQN from Elasticsearch as it is what we need.

We are also setting the default batchSize from the PeriodicBatchEntityTrigger to 500.

Other than that we are also transforming the workflow after the startEvent into async behaviour to be able to trigger the workflow without waiting for it to finish.

Type of change:

- [x] Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@IceS2 IceS2 changed the title MINOR: Add annotation to turn delete_recursive test into the last one to be executed MINOR: Governance Workflows fixes Nov 22, 2024
pmbrull
pmbrull previously approved these changes Nov 22, 2024
Copy link

@harshach harshach merged commit b3d765d into main Nov 24, 2024
14 of 19 checks passed
@harshach harshach deleted the fix-flaky-glossary-test branch November 24, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants