Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Set Certification Field Dynamically #18874

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Dec 2, 2024

If the Certification Tag Entity was updated, the changes were not reflected on already certified entities.
This was due to the Certification field not being fetched dynamically.

This PR aims to fetch the Certification Field when requesting Tags in a Dynamic fashion, while only saving the relevant information on the TagLabel within the Entity.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@IceS2 IceS2 requested a review from a team as a code owner December 2, 2024 10:00
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 2, 2024
Copy link

sonarqubecloud bot commented Dec 3, 2024

@IceS2 IceS2 enabled auto-merge (squash) December 4, 2024 14:31
@pmbrull pmbrull disabled auto-merge December 4, 2024 14:36
@pmbrull pmbrull merged commit e2789da into main Dec 4, 2024
16 of 19 checks passed
@pmbrull pmbrull deleted the set-certification-dynamically branch December 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants