-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR - FQN encoding in ometa_api, TestSuite pipeline creation & serialization of test case results #18877
Conversation
@@ -84,7 +84,7 @@ | |||
"sourceConfig": { | |||
"config": { | |||
"type": "TestSuite", | |||
"entityFullyQualifiedName": f'datalake_for_integration_tests.default.{BUCKET_NAME}."users.csv"', | |||
"entityFullyQualifiedName": f'datalake_for_integration_tests.default.{BUCKET_NAME}."users/users.csv"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding the file in a directory to test the encoding properly
ingestion/src/metadata/data_quality/validations/base_test_handler.py
Outdated
Show resolved
Hide resolved
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Describe your changes:
Fixes
Solving three issues:
df[col].count()
test) for the passed/failed rows, which cannot be automatically serialized. The types should beint
, so we're ensuring the cast there. I'd rather cast it generally than missing some test.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>