Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - FQN encoding in ometa_api, TestSuite pipeline creation & serialization of test case results #18877

Merged
merged 7 commits into from
Dec 2, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Dec 2, 2024

Describe your changes:

Fixes

Solving three issues:

  1. We were not encoding the FQN in some places in the ometa_api Mixins. This made the ingestion pipeline status update fail in the client
  2. Pandas validator might return numpy types (e.g., for the df[col].count() test) for the passed/failed rows, which cannot be automatically serialized. The types should be int, so we're ensuring the cast there. I'd rather cast it generally than missing some test.
  3. If we tried to run a YAML passing an Ingestion Pipeline that was not yet created in the UI, the creation logic failed, since we were not properly referencing the TestSuite service type

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@@ -84,7 +84,7 @@
"sourceConfig": {
"config": {
"type": "TestSuite",
"entityFullyQualifiedName": f'datalake_for_integration_tests.default.{BUCKET_NAME}."users.csv"',
"entityFullyQualifiedName": f'datalake_for_integration_tests.default.{BUCKET_NAME}."users/users.csv"',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding the file in a directory to test the encoding properly

TeddyCr
TeddyCr previously approved these changes Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

sonarqubecloud bot commented Dec 2, 2024

@pmbrull pmbrull merged commit 7aacfe0 into open-metadata:main Dec 2, 2024
18 of 22 checks passed
@pmbrull pmbrull deleted the ingestion-test branch December 2, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants