Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a relationship to manage ER based on tableConstraints #18892

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Create a relationship to manage ER based on tableConstraints #18892

merged 9 commits into from
Dec 4, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Dec 2, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner December 2, 2024 23:45
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 2, 2024
@harshach
Add relationship/remove relationship from entity_relationship table w…
bfaad28 
…henever table constriants are updated/added , validate table constraints
pmbrull
pmbrull previously approved these changes Dec 3, 2024
View reviewed changes
@pmbrull pmbrull self-requested a review December 3, 2024 08:49
@pmbrull pmbrull dismissed their stale review December 3, 2024 08:49

need to fix migrations

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@harshach harshach merged commit bf00c9c into main Dec 4, 2024
21 of 26 checks passed
@harshach harshach deleted the fix_queries_er branch December 4, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshach @pmbrull