Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: fix table/schema name #18899

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Dec 3, 2024

Describe your changes:

  • Fix tablename and schema name in table system metrics
  • Fix dbt workflow error
  • Fix user sample query errors in profiler and DQ
  • Move config elements to advanced
  • Update sampling method doc

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

sushi30
sushi30 previously approved these changes Dec 3, 2024
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 3, 2024
pmbrull
pmbrull previously approved these changes Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.74% (40309/63235) 40.23% (16043/39883) 42.58% (4799/11270)

@TeddyCr TeddyCr enabled auto-merge (squash) December 3, 2024 15:51
@TeddyCr TeddyCr disabled auto-merge December 4, 2024 06:56
Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link

sonarqubecloud bot commented Dec 4, 2024

@TeddyCr TeddyCr merged commit a615f49 into open-metadata:main Dec 4, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants