-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Fix Glossary Term Consolidation and Flaky Test #18920
Conversation
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
…adata/OpenMetadata into fix-glossary-term-consolidation
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
This PR Aims to fix two different things:
Fix Flaky GlossaryTermResourceTest
In order to fix the flaky
patch_addDeletedReviewers
test we are now patching the GlossaryTerm and waiting for the task to be created to guarantee this task status will beIN_REVIEW
. After that we can assert what we need to.Fix Consolidation Changes on GlossaryTerms throwing an exception when it shouldn't for certain corner case.
In order to fix the Consolidation Changes we are passing the context to the
updateInternal
method.Since we use the same flow both for updating an entity and reversing an entity for cosolidation, we decided to add this flag to ignore the
checkUpdatedByReviewer
check if we are inside the consolidation changes. This is supposed to be a solution until we are able to take a closer look at the whole consolidation flow.There is also a small change on the playwright tests for Glossary to avoid a possible
IN_REVIEW
state that would not allow us to assign a glossaryTerm as related term.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>