Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix Glossary Term Consolidation and Flaky Test #18920

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Dec 4, 2024

This PR Aims to fix two different things:

  1. Fix Flaky GlossaryTermResourceTest
    In order to fix the flaky patch_addDeletedReviewers test we are now patching the GlossaryTerm and waiting for the task to be created to guarantee this task status will be IN_REVIEW. After that we can assert what we need to.

  2. Fix Consolidation Changes on GlossaryTerms throwing an exception when it shouldn't for certain corner case.
    In order to fix the Consolidation Changes we are passing the context to the updateInternal method.
    Since we use the same flow both for updating an entity and reversing an entity for cosolidation, we decided to add this flag to ignore the checkUpdatedByReviewer check if we are inside the consolidation changes. This is supposed to be a solution until we are able to take a closer look at the whole consolidation flow.

There is also a small change on the playwright tests for Glossary to avoid a possible IN_REVIEW state that would not allow us to assign a glossaryTerm as related term.

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.74% (40309/63235) 40.23% (16043/39883) 42.58% (4799/11270)

pmbrull
pmbrull previously approved these changes Dec 4, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link

sonarqubecloud bot commented Dec 4, 2024

@IceS2 IceS2 enabled auto-merge (squash) December 4, 2024 18:30
@IceS2 IceS2 merged commit 46d4e1c into main Dec 5, 2024
25 of 27 checks passed
@IceS2 IceS2 deleted the fix-glossary-term-consolidation branch December 5, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants